Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorize match_trajectory_sets #764

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Vectorize match_trajectory_sets #764

merged 2 commits into from
Dec 18, 2024

Conversation

jeremykubica
Copy link
Contributor

The new match_trajectory_sets() function is running too slowly in even small clustering tests. This vectorizers it. It also breaks out the logic for extracting column information from a list of trajectories, makes that a module, and calls it from Results.

drewoldag
drewoldag approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. It looks like match_trajectory_sets already had reasonable test coverage, prior to this change, so no major concerns about a regression here.

@jeremykubica jeremykubica merged commit 03395e1 into main Dec 18, 2024
2 checks passed
@jeremykubica jeremykubica deleted the testing_helpers branch December 18, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewoldag drewoldag drewoldag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremykubica @drewoldag